New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of DocumentLink with at least one broken link returns None #61

Open

rguilbault opened this issue Jun 25, 2018 · 1 comment · May be fixed by #62

rguilbault commented Jun 25, 2018 •

edited

Loading

Hi,

In a document, I have the following structure :

a fragment XXX of type Group
- for each document inside the group, a unique fragment, called YYY, with a DocumentLink.

If in this group, I have at least one DocumentLink which is broken, the fragment XXX returns None, and not Some(Group(List(...))). Is this the expected behaviour ?

Tested on scala 2.11, prismic-kit 2.4.2

Thank you !

Ronan

The text was updated successfully, but these errors were encountered:

rguilbault changed the title ~~List of DocumentLink with at least one broken link return None instead of Some(List(...))~~ List of DocumentLink with at least one broken link return None

rguilbault changed the title ~~List of DocumentLink with at least one broken link return None~~ List of DocumentLink with at least one broken link returns None

Author

rguilbault commented Jun 26, 2018 •

edited

Loading

Ok, I think I founded the bug :

When a DocumentLink is broken, the lang attribute is a null
However, in PrismicJsonProtocol.scala, it try to convert JsNull spray library to a String... which is apparently not possible.

rguilbault added a commit to rguilbault/scala-kit that referenced this issue


           prismicio-community#61 Fix Group None value if contains broken Docum…

34b2766

…entLink

rguilbault linked a pull request

that will close this issue

#61 Group with broken DocumentLink #62

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment