Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jinja2 is not pinned for sphinx #241

Open
SmartManoj opened this issue Oct 25, 2024 · 2 comments · May be fixed by #243
Open

Jinja2 is not pinned for sphinx #241

SmartManoj opened this issue Oct 25, 2024 · 2 comments · May be fixed by #243
Assignees
@john-b-yang
Labels
bug Something isn't working

Comments

@SmartManoj
Copy link

SmartManoj commented Oct 25, 2024 •
edited
Loading

Describe the bug

SWE-bench/swebench/harness/constants.py

Line 496 in fe8cb2e

"pip_packages": ["tox==4.16.0", "tox-current-env==0.0.11"],

pip show jinja2 v2.11.2

.tox/py39/bin/python -m pip show jinja2 v3.1.4

Relevant issues:
sphinx-doc/sphinx#10291 (comment)

Steps/Code to Reproduce

tox -e py39

Expected Results

No error

Actual Results

Error:
ImportError: cannot import name 'environmentfilter' from 'jinja2'

Trajectory

System Information

No response
@SmartManoj SmartManoj added the bug Something isn't working label Oct 25, 2024
@john-b-yang john-b-yang self-assigned this Oct 25, 2024
@john-b-yang
Copy link
Collaborator

@SmartManoj if you know what the issue is, would you mind writing a pull request that fixes this issue? Thanks.

@SmartManoj
Copy link
Author

SmartManoj commented Oct 28, 2024 •
edited
Loading

Sure.

For sphinx-doc__sphinx-8595, .tox/py39/bin/python -m pip install "Jinja2<3.1" solved.

SmartManoj added a commit to SmartManoj/SWE-bench that referenced this issue Oct 28, 2024
@SmartManoj
Pin Jinja2 to version <3.1 for Sphinx
094af5f 
Fixes princeton-nlp#241

Pin Jinja2 to version <3.1 for Sphinx in `swebench/harness/constants.py`.

* Add `Jinja2<3.1` to the `pip_packages` list for Sphinx in the `SPECS_SPHINX` dictionary.


Reference: https://www.ingap.dev/posts/solved-cannot-import-name-environmentfilter-from-jinja2

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/princeton-nlp/SWE-bench/issues/241?shareId=XXXX-XXXX-XXXX-XXXX).
@SmartManoj SmartManoj linked a pull request Oct 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@john-b-yang john-b-yang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin Jinja2 to version <3.1 for Sphinx SmartManoj/SWE-bench
2 participants
@SmartManoj @john-b-yang