Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoMethodError when checking if ActionList::Dividers are active #3254

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

camertron
Copy link
Contributor

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

This change adds an active? method to ActionList::Divider. This is necessary so all types of item implement the same interface.

For additional background, the items slot on ActionList is polymorphic, i.e. allows multiple kinds of item. Currently supported items are 1) regular 'ol items, 2) avatar items, and 3) dividers. Both regular and avatar items define active?, but Divider does not. In at least one place we iterate over all items, attempting to call active? on each of them. If one is a Divider, Ruby raises a NoMethodError.

Integration

No changes necessary in production.

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Accessibility

  • No new axe scan violation - This change does not introduce any new axe scan violations.

Merge checklist

  • Added/updated tests
    - [ ] Added/updated documentation
    - [ ] Added/updated previews (Lookbook)
    - [ ] Tested in Chrome
    - [ ] Tested in Firefox
    - [ ] Tested in Safari
    - [ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: d5511b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron marked this pull request as ready for review January 8, 2025 17:36
@camertron camertron requested a review from a team as a code owner January 8, 2025 17:36
@camertron camertron requested review from mperrotti and jonrohan and removed request for mperrotti January 8, 2025 17:36
@camertron camertron merged commit 1bb7ad7 into main Jan 8, 2025
34 checks passed
@camertron camertron deleted the fix_actionlist_divider_active branch January 8, 2025 22:10
@primer primer bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants