Fix NoMethodError
when checking if ActionList::Divider
s are active
#3254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: Please fill out this form carefully and completely.
Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.
What are you trying to accomplish?
This change adds an
active?
method toActionList::Divider
. This is necessary so all types of item implement the same interface.For additional background, the
items
slot onActionList
is polymorphic, i.e. allows multiple kinds of item. Currently supported items are 1) regular 'ol items, 2) avatar items, and 3) dividers. Both regular and avatar items defineactive?
, butDivider
does not. In at least one place we iterate over all items, attempting to callactive?
on each of them. If one is aDivider
, Ruby raises aNoMethodError
.Integration
No changes necessary in production.
Risk Assessment
Accessibility
Merge checklist
- [ ] Added/updated documentation- [ ] Added/updated previews (Lookbook)- [ ] Tested in Chrome- [ ] Tested in Firefox- [ ] Tested in Safari- [ ] Tested in EdgeTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.