Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set a test_selector on Primer::Alpha::Item#description #2970

Closed
sampart opened this issue Jul 26, 2024 · 2 comments · Fixed by #2984
Closed

Add ability to set a test_selector on Primer::Alpha::Item#description #2970

sampart opened this issue Jul 26, 2024 · 2 comments · Fixed by #2984
Assignees
@sampart
Labels
enhancement New feature or request rails

Comments

@sampart
Copy link
Contributor

sampart commented Jul 26, 2024

This would be really useful in tests. Thanks!
@sampart sampart added the enhancement New feature or request label Jul 26, 2024
@sampart sampart self-assigned this Jul 26, 2024
@sampart sampart mentioned this issue Jul 26, 2024
Closed
10 tasks
@camertron
Copy link
Contributor

Hey @sampart! Anything I can help with here to get this over the finish line?

@sampart
Copy link
Contributor Author

sampart commented Jul 30, 2024

Thanks @camertron! As far as I'm concerned, #2971 is ready, but I'm getting odd CI failures, so I didn't feel able to make it non-draft yet.m Would you be able to take a look? Thanks

@camertron camertron mentioned this issue Jul 30, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sampart sampart

Labels
enhancement New feature or request rails
Projects
None yet
Milestone
No milestone
2 participants
@camertron @sampart