Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid value for symbolicon.constant in dark theme variants. #409

Open
DavidSeptimus opened this issue Feb 3, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@DavidSeptimus
Copy link

Description

Most of the dark variants include an array of colors for symbolicon.constant when the schema expects a string. VS Code ignores the invalid value (the constant icon displays as white), but other libraries/tools may fail to parse the theme because of that value.

Image

(see shikijs/shiki#894).

Steps to reproduce

  1. Enable one of the affected dark variants in VS Code.
  2. Open a new python document and enter the following:
MY_CONST = "val"
  1. Open the command palette and activate Explorer: Focus on Outline View
  2. Check the outline view in the bottom-left corner and you'll see that MY_CONST's icon is white because the array of green colors associated with symbolicon.constant in the theme is an invalid value.

Version

v6.3.5

Theme

GitHub Dark High Contrast, GitHub Dark Default, GitHub Dark Colorblind, GitHub Dark Dimmed, GitHub Dark

@DavidSeptimus DavidSeptimus added the bug Something isn't working label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant