You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the ActionMenu component, selection is ignored if the item's value is falsy (including here where it's intentionally 0). I understand we might have wanted this check to filter out invalid items so, if kept, maybe checking newValue against undefined instead would do? We might intentionally want to use null or false as values.
This is currently non-blocking for my use case since I'm working with numeric values (see ugly temp workaround below), but it might be different for a user who needs to use null or false for example. Thanks.
1. Setup an `ActionMenu` component with two items: one whose value is falsy (including but not limited to `undefined`), the other not.
2. Open the browser and attempt to selectthe first item in the menu
3. Observe that it cannot be selected
Expected behavior
`ActionMenu` items should be selectable even if they have a falsy value, unless it is specifically `undefined`.
Screenshots
CleanShot.2025-01-24.at.13.50.53.mp4
Browsers
Chrome
OS
Mac
The text was updated successfully, but these errors were encountered:
Describe the bug
In the
ActionMenu
component, selection is ignored if the item's value is falsy (including here where it's intentionally0
). I understand we might have wanted this check to filter out invalid items so, if kept, maybe checkingnewValue
againstundefined
instead would do? We might intentionally want to usenull
orfalse
as values.This is currently non-blocking for my use case since I'm working with numeric values (see ugly temp workaround below), but it might be different for a user who needs to use
null
orfalse
for example. Thanks.Reproduction steps
Expected behavior
Screenshots
CleanShot.2025-01-24.at.13.50.53.mp4
Browsers
Chrome
OS
Mac
The text was updated successfully, but these errors were encountered: