Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CofirmDialog styles only apply to the root and transitions #308

Closed
aDogCalledSpot opened this issue Aug 1, 2024 · 2 comments
Closed

CofirmDialog styles only apply to the root and transitions #308

aDogCalledSpot opened this issue Aug 1, 2024 · 2 comments

Comments

@aDogCalledSpot
Copy link

aDogCalledSpot commented Aug 1, 2024

I'm using PrimeVue version 4.0.0.

I copied the default lara configuration from the documentation. The styles for the "root" and "transition" component are being applied but not for any of the other components.

For the following code then:

const deleteConfirm = () => {
  confirm.require({
    message: 'Are you sure you want to delete this',
    header: 'Confirmation',
    // position: 'top',
    rejectProps: {
      label: 'Cancel',
      severity: 'secondary',
      outlined: true,
    },
    acceptProps: {
      label: 'Delete',
      severity: 'danger',
    },
    accept: () => {
      console.log('deleted')
    },
    reject: () => {
      console.log('canceled')
    },
  })
}

The result looks like this:

image


I noticed there is a mismatch between the code in the documentation mentioned above and the code in this repository for the ConfirmDialog. Is this intended?

@aDogCalledSpot aDogCalledSpot changed the title CofirmDialog styles only apply to the root CofirmDialog styles only apply to the root and transitions Aug 1, 2024
@aDogCalledSpot
Copy link
Author

Despite working, the transition field also isn't listed in the ConfirmDialogPassThroughOptions which is unfortunate since I'm using TypeScript for my preset.

@cagataycivici
Copy link
Member

As of v4.1.1, the new Tailwind styles have been rewritten using the preprocessor approach with @apply instead of pass-through. As a result this issue is not relevant any more.

New Website is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants