Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong severity check #214

Closed
Caarnus opened this issue Apr 12, 2024 · 3 comments
Closed

Wrong severity check #214

Caarnus opened this issue Apr 12, 2024 · 3 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@Caarnus
Copy link

Caarnus commented Apr 12, 2024

Repository URL

https://github.com/primefaces/primevue-tailwind/blob/main/presets/wind/splitbutton/index.js

@Caarnus Caarnus added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 12, 2024
@Caarnus
Copy link
Author

Caarnus commented Apr 12, 2024

In the splitbutton Wind preset there is a check for secondary on lines 84 and 272 instead of for success:

// Success Text Button
{ 'text-surface-500 dark:text-surface-400': parent.props.text && parent.props.severity === 'secondary' && !parent.props.plain },

// Success Text Button
{ 'text-surface-500 dark:text-surface-400': parent.props.text && parent.props.severity === 'secondary' && !parent.props.plain },

@Caarnus
Copy link
Author

Caarnus commented Apr 12, 2024

Create PR #215 to address

@atakantepe
Copy link
Member

Thank you for your PR, but the Wind preset is no longer part of the official presets. It has been replaced with the Aura Preset.

You can add this PR and the issue to the Wind Preset Github repo. I would be happy to merge it.

❗Wind Preset has been moved (w/ v0.9.0)❗ #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

2 participants