Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: mobile CSS loses spaces between classes #5632

Closed
pijusjuodis opened this issue Dec 21, 2023 · 3 comments
Closed

Themes: mobile CSS loses spaces between classes #5632

pijusjuodis opened this issue Dec 21, 2023 · 3 comments
Labels
Component: Theme Issue or pull request is related to Theme Device: Mobile Issue or pull request is *only* related to Mobile device Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response

Comments

@pijusjuodis
Copy link

Describe the bug

Could not reproduce in the codebox, but with primereact 10.2.1 I started to have issues appearing on a random basis, where on mobile devices the imported CSS loses the spaces between class names. For example:
..p-menubar .p-menubar-button gets compiled as .p-menubar.p-menubar-button - which leads to mobile view look unstyled.

I'm using symfony webpack encore bundle and npm to compile the assets. The issue is not appearing if I downgrade to 9.6.2 version

Reproducer

No response

PrimeReact version

10.2.1

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@pijusjuodis pijusjuodis added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 21, 2023
@melloware
Copy link
Member

melloware commented Dec 23, 2023

I wonder if this has to do with the CSS Layers introduced in PR10..

@layer primereact {

@melloware melloware added Device: Mobile Issue or pull request is *only* related to Mobile device Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 23, 2023
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you with the latest version, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response label Dec 18, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you for your understanding!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Device: Mobile Issue or pull request is *only* related to Mobile device Resolution: Stale Issue or pull request is inactivity and unfortunately it will be *closed* if there is no response
Projects
None yet
Development

No branches or pull requests

2 participants