Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast: Update themes removing border-width TOAST #5631

Open
SoyDiego opened this issue Dec 21, 2023 · 0 comments
Open

Toast: Update themes removing border-width TOAST #5631

SoyDiego opened this issue Dec 21, 2023 · 0 comments
Assignees
@mertsincan @gucal
Labels
Component: Theme Issue or pull request is related to Theme
Milestone
Future

Comments

@SoyDiego
Copy link
Contributor

Describe the bug

You can have more context about the problem here:

ISSUE: primefaces/primereact-sass-theme#45
PR: primefaces/primereact-sass-theme#46

I realized in some devices/browsers/OS (I don't know exactly), the Toast component is generating a unnecessary border.
You cannot replicate in the website, but in Linux, firefox and my project I can see this problem.

image

The problem is the border-width. Is not necessary in this place.

Reproducer

PrimeReact version

Last version

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Linux, Safari

Steps to reproduce the behavior

Expected behavior

No response
@SoyDiego SoyDiego added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 21, 2023
@SoyDiego SoyDiego mentioned this issue Dec 21, 2023
Closed
@melloware melloware added Status: Discussion Issue or pull request needs to be discussed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 21, 2023
@melloware melloware added this to the Future milestone Dec 21, 2023
@melloware melloware added Component: Theme Issue or pull request is related to Theme and removed Status: Discussion Issue or pull request needs to be discussed by Core Team labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

@gucal gucal

Labels
Component: Theme Issue or pull request is related to Theme
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

fix(themes): Update themes - remove border-width TOAST SoyDiego/primereact
4 participants
@melloware @mertsincan @SoyDiego @gucal