-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update joda-time dependency from 2.8.2 to 2.9.9. #8153
Comments
I filed an issue with joda. But I don't expect that it will be fixed. JodaOrg/joda-time#427 I believe the best way to address this is to:
|
After a discussion with @martint, we decide that this is not a significant enough issue for Presto. We'll just update to joda 2.9.9 with a release notes mentioning this known bug. |
We should increase the minimum Java version if this will cause incorrect results on older versions. As we've seen many times, users often miss release notes.
|
That's a bit heavy-handed. The issue affects a single timezone that is unlikely to be used by any Presto user in practice. Some users may not be able to update to the latest version of Java so easily. It's better to just document it as a known issue. |
Actually joda update also includes 2 years worth of DST adjustments as
well. While operating on time series data, international timestamp
conversions deviates several hours in such cases without this update.
Other alternatives may be including the updated joda library manually or
recompiling presto with updated pom.
…On Jun 1, 2017 20:59, "Martin Traverso" ***@***.***> wrote:
We should increase the minimum Java version if this will cause incorrect
results on older versions. As we've seen many times, users often miss
release notes.
That's a bit heavy-handed. The issue affects a single timezone that is
unlikely to be used by any Presto user in practice. Some users may not be
able to update to the latest version of Java so easily. It's better to just
document it as a known issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#8153 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF3euYE1uRDhYb5IBHbvSD0UFdjH4l5Tks5r_vvsgaJpZM4Nre3w>
.
|
Fixed by #8156. |
Please update joda-time dependency version from 2.8.2 to 2.9.9.
Version 2.8.2 is released nearly 2 years ago (Aug 11, 2015) and contains out of date time-zone data, resulting in errors in date-time functions.
The text was updated successfully, but these errors were encountered: