From b5b0b02edc20ef6cffae32c462215b0b7ba36b72 Mon Sep 17 00:00:00 2001 From: Lily Kuang Date: Thu, 2 Mar 2023 15:47:50 -0800 Subject: [PATCH] fix: embedded dashboards throwing console errors --- package-lock.json | 4 ++-- package.json | 2 +- src/index.ts | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 489e205..18c3570 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@preset-sdk/embedded", - "version": "0.1.5", + "version": "0.1.6", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@preset-sdk/embedded", - "version": "0.1.5", + "version": "0.1.6", "license": "UNLICENSED", "dependencies": { "@superset-ui/switchboard": "^0.18.26-0" diff --git a/package.json b/package.json index a1796aa..d992c0b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@preset-sdk/embedded", - "version": "0.1.5", + "version": "0.1.6", "description": "Frontend SDK for embedding Preset data analytics into your own application", "access": "public", "keywords": [ diff --git a/src/index.ts b/src/index.ts index cbc22f5..a846135 100644 --- a/src/index.ts +++ b/src/index.ts @@ -96,6 +96,7 @@ export async function embedDashboard({ }); iframe.src = `${supersetDomain}/embedded/${id}${dashboardConfig}`; + //@ts-ignore mountPoint.replaceChildren(iframe); log('placed the iframe') }); @@ -119,6 +120,7 @@ export async function embedDashboard({ function unmount() { log('unmounting'); + //@ts-ignore mountPoint.replaceChildren(); }