Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refreshGuestToken() runs indefinitely (and stacks!) #16

Closed
gamma613 opened this issue Nov 3, 2023 · 1 comment
Closed

refreshGuestToken() runs indefinitely (and stacks!) #16

gamma613 opened this issue Nov 3, 2023 · 1 comment

Comments

@gamma613
Copy link

gamma613 commented Nov 3, 2023

In our react application, I've observed that superset embeds will continue running refreshGuestToken() after I've left the page that has the embed.

What's more, if I re-visit a page embedding a dashboard multiple times, it has a stacking effect - ie: if I visit the dashboard 6 times, it will now make 6 calls to refreshGuestToken().

I've tried calling dashboard.unmount() when my page unloads - which successfully removes the iframe, but it doesn't cause the setTimeout for refreshGuestToken() to be cancelled.

Not sure what other things could be floating around in memory as well.

@Vitor-Avila
Copy link
Contributor

Addressed here #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants