-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource defines not applied for VC201x projects (at all!) #10
Comments
Other solutions are obviously possible, notably We're looking for the name "e" first, because LuaSrcDiet shortens the variable name "cfg" to that. If we fail, we try again with the original name. After that we assert that it's non- |
If you submit this as a PR (as a direct modification of the core core, rather than a patch) I'll be happy to merge it. |
Hey @starkos , of course this above solution makes no sense as PR. Because it should be fixed in Premake4 so that above workaround isn't necessary anymore (simply by patching I'll try to submit the patches I have ready in my fork until the end of the year. No promises, though. Until then I am keeping that cookbook article in the Wiki up-to-date. I hope that this will be valuable to others running into similar issues. |
Also working around the Premake4 issue with resource_compile(), see premake/premake-4.x#10
Also working around the Premake4 issue with resource_compile(), see premake/premake-4.x#10
The current code, namely vs2010_vcxproj.lua doesn't use
resdefines
at all. I just noticed this by accident. I'll definitely write a Lua-only workaround for this, but I still need to set up myself to contribute back changes from my (still Mercurial based) repo.Unfortunately the function
preprocessor
is alocal
one, which makes the planned workaround more cumbersome than it would otherwise be. Likely another case whereio.capture()
is called for.The text was updated successfully, but these errors were encountered: