Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename [x-dependencies] to [package.x-dependencies]? #2798

Closed
tdejager opened this issue Jan 2, 2025 · 3 comments · Fixed by #2731 or #2718
Closed

rename [x-dependencies] to [package.x-dependencies]? #2798

tdejager opened this issue Jan 2, 2025 · 3 comments · Fixed by #2731 or #2718
Assignees
Labels
area:build Related to pixi build ✨ enhancement Feature request

Comments

@tdejager
Copy link
Contributor

tdejager commented Jan 2, 2025

Currently its quite confusing that some things belong to package and the other to the workspace/project. The following specification would be a way to rectify this:

[package]
name = "foobar"
version = "0.1.0" 

[package.build]
backend = { name = "pixi-build-python", version = "*" }

# Question: should channels also be part of build-backend perhaps?
channels = []

# I think this can be achieved in JSON schema if we can match on 
# `package.build.backend.name` == `pixi-build-python`
#
# Question: Is `args` a good enough name?
[tool.pixi-build-python]
noarch = true

[package.host-dependencies]
python = "3.11"
meson-py = "*"

[package.build-dependencies]
cxx-compilers = "*"

[package.run-dependencies]
foobar-ext = "*"

[package.variants]
python = []


# Workspace keys are not nested
[workspace]

[dependencies]
foobar = { source = "." }

[feature]
[environments
[pypi-options]
@tdejager tdejager added the ✨ enhancement Feature request label Jan 2, 2025
@tdejager tdejager added the area:build Related to pixi build label Jan 3, 2025
@baszalmstra baszalmstra reopened this Jan 6, 2025
@baszalmstra
Copy link
Contributor

#2731 needs to go in before this is done.

@baszalmstra
Copy link
Contributor

What should we do with target?

[target.osx-64.host-dependencies]
package1 = { version = ">=1.2.3", build = "py34_0" }

Since host-dependencies is now:

[package.host-dependencies]

Should we do ?

[package.target.osx-64-host-dependencies]

@ruben-arts
Copy link
Contributor

Assuming you meant [package.target.osx-64.host-dependencies] I think that is fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build Related to pixi build ✨ enhancement Feature request
Projects
None yet
3 participants