Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openx setting wrong field #12799

Closed
patmmccann opened this issue Feb 21, 2025 · 3 comments
Closed

Openx setting wrong field #12799

patmmccann opened this issue Feb 21, 2025 · 3 comments
Assignees
@dgirardi

Comments

@patmmccann
Copy link
Collaborator

#12695 (comment) sets bid.mtype. Did you mean to set bid.meta.mediaType? eg as #12484
@marcin-wrobel-ox
Copy link
Contributor

This is set on purpose to satisfy this https://github.com/prebid/Prebid.js/blob/master/libraries/pbsExtensions/processors/mediaType.js#L14
in case if seatbid.bid[].mtype is not set

@dgirardi dgirardi self-assigned this Feb 24, 2025
@dgirardi dgirardi moved this from Triage to Needs OP in Prebid.js Tactical Issues table Feb 24, 2025
@dgirardi
Copy link
Collaborator

Code looks correct to me:

https://github.com/openx/Prebid.js/blob/679bfc3e172a11429b8e8d8b87c7bfb67c610faa/modules/openxBidAdapter.js#L83-L95

sets the ORTB mtype before sending it down for conversion. Setting context.mediaType directly would be better since it avoids the double translation, but I don't see a problem with the current version.

@patmmccann
Copy link
Collaborator Author

I think I was confused, I thought #12695 was to declare ibv given there has been so much of that activity of late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgirardi dgirardi

Labels
None yet
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patmmccann @dgirardi @marcin-wrobel-ox