Debugging module: make mock creatives respect requested sizes #12804
Conversation
|
Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):
|
dgirardi
force-pushed
the
fix-mock-banner
branch
from
2b88666 to
e224df0
Compare
dgirardi
force-pushed
the
fix-mock-banner
branch
from
e224df0 to
2fee8c1
Compare
|
What does this end up looking like? I think the images in the issue would look fine if they were stretched instead of cutoff? |
|
seeing the bidder name was/ is very useless in the "old" images, if you have "multiple" bidders, the new images doesnt show this, if it did great, if it "fit to size" even better, agreed the "new" image looks better than just a "yellow box" |
|
@spormeon so you like the new image but not the sizing and cutoffs? |
| }, | ||
| [VIDEO]: (bid, bidResponse) => { | ||
| if (!bidResponse.hasOwnProperty('vastXml') && !bidResponse.hasOwnProperty('vastUrl')) { | ||
| bidResponse.vastXml = '<?xml version="1.0" encoding="UTF-8"?><VAST version="3.0"><Ad><InLine><AdSystem>GDFP</AdSystem><AdTitle>Demo</AdTitle><Description><![CDATA[Demo]]></Description><Creatives><Creative><Linear ><Duration>00:00:11</Duration><VideoClicks><ClickThrough><![CDATA[https://prebid.org/]]></ClickThrough></VideoClicks><MediaFiles><MediaFile delivery="progressive" width="640" height="360" type="video/mp4" scalable="true" maintainAspectRatio="true"><![CDATA[https://s3.amazonaws.com/files.prebid.org/creatives/PrebidLogo.mp4]]></MediaFile></MediaFiles></Linear></Creative></Creatives></InLine></Ad></VAST>'; |
There was a problem hiding this comment.
@ChrisHuie this would be nice to have somewhere served with application/xml content type
dgirardi
changed the title
dgirardi
changed the title
|
@patmmccann ye, i like the new one, its more "branded" i guess, couldn't the same be also achieved with using the "old" yellow, but change to this "new" blue, with "Prebid logo" - "Prebid Mock Creative" and leave the bidder name & size there as before. The bidder and the size is actualy useful to me eye, as can quickly/ easily see whats what etc |
Type of change
Description of change
When mocking a banner ad with the debugging module, restore the old creatives from before #12720 (fixes #12796)
While the new image is nicer, it isn't if we try to fit it to a different aspect ratio IMO - open to reconsider.