Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect jsx type definition #328

Closed
acelaya opened this issue Jan 11, 2024 · 2 comments · Fixed by #329
Closed

Incorrect jsx type definition #328

acelaya opened this issue Jan 11, 2024 · 2 comments · Fixed by #329

Comments

@acelaya
Copy link
Contributor

acelaya commented Jan 11, 2024

We have just started to use preact-render-to-string/jsx and noticed TypeScript complains because jsx.d.ts includes two default exports.

As a temporary workaround we have created our own definition and referenced it via tsconfig's paths option.

We could provide a fix for this if desired, consisting in removing the last export default render;, which looks like an overlook.
@marvinhagemeister
Copy link
Member

Good catch, feel free to send a PR. The last default export is definitely a mistake and shouldn't be there.

@acelaya acelaya mentioned this issue Jan 11, 2024
Merged
@acelaya
Copy link
Contributor Author

acelaya commented Jan 11, 2024

Thanks! Here's the PR #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove incorrect second default export from jsx.d.ts acelaya-forks/preact-render-to-string
2 participants
@marvinhagemeister @acelaya