Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support disconnected omega ranges #88

Open
ddale opened this issue Dec 17, 2014 · 2 comments
Open

support disconnected omega ranges #88

ddale opened this issue Dec 17, 2014 · 2 comments
Assignees
Milestone

Comments

@ddale
Copy link
Member

ddale commented Dec 17, 2014

extend the config.imageseries.ImageSeriesConfig class to allow either ints or list of ints for omega:start, omega:stop, and omega:step. Lists should be all the same length, and will be zipped together to provide a list of ranges:

ranges = [range(start, stop, step) for start, stop, step in zip(ome.start, ome.stop, ome.step)]

Also, add a property that returns a list (or np array?) of omega values.

@joelvbernier, in what form are the disconnected omega ranges consumed by the library? Does it need a list of ranges, or a list of discrete omega values?

@ddale ddale self-assigned this Dec 17, 2014
@ddale ddale added this to the 0.3.0 milestone Dec 17, 2014
@joelvbernier
Copy link
Contributor

My thought was a list of suspects just as for a single range. That is, a start and a Delta, and (optionally?) a stop. One obvious use case is for something like a diamond anvil cell where you cannot do 360, but you can do symmetric wedges on each side of the cell

@ddale
Copy link
Member Author

ddale commented Dec 20, 2014

From the Zen of Python: "explicit is better than implicit". I have a very strong aversion to inferring the stop angle from the start angle, the step angle, and the number image frames. I think the stop angle should be specified.

See pull request #91.

@ddale ddale assigned joelvbernier and unassigned ddale Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants