-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mt_tps does not seem to affect number of messages hitting the SMPP endpoint #1076
Comments
Hi @Telewa The If this is not correctly throttling messages, then it's possible that there is a bug in the throttling code. Do you see anything about throttling in the logs? There are a number of logs for various throttling actions at the I would suggest looking at https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/smpp_service.py#L74-L194 for a start at the throttling code. Our contributing guidelines can be found at: https://github.com/praekelt/vumi/blob/develop/CONTRIBUTING.rst |
Thank you @rudigiesler, Yes I can see throttle messages. |
@Telewa If it's not then it's possible that there's a bug somewhere in the throttling code that we haven't been able to pick up on. |
@rudigiesler just a clarification, does in case it is, how can we make this parameter dynamic ? |
No, we're not using the window manager in the SMPP transport. We're using a twisted looping call: https://twistedmatrix.com/documents/current/api/twisted.internet.task.LoopingCall.html . It's hardcoded to a window size of 1 second: https://github.com/praekelt/vumi/blob/e179b69296f368ce4ad6bce34f96c73df675c8b3/vumi/transports/smpp/smpp_service.py#L59 , I don't see any reason to change this though. I don't think that we need a window size smaller than 1 second. |
Cool. Thanks @rudigiesler for the clarification. Do you confirm however, that if we have 100 messages in rabbitmq vumi outbound queue, to be sent out, and we have set the |
Yes, if you're using the SMPP transport then that should be the case. If it doesn't limit the sending rate, then there's possibly a bug in the SMPP transport. |
Thanks a lot @rudigiesler. i'll look at the code then. There could be a bug somewhere. |
We have
mt_tps
set to 1.However, if 100 messages are queued in the outbound queue, all of them seem to be sent in less than a minute. (SMPP) This causes issues where the terms of usage require that only 1 message is sent per second. How can we ensure that only 1 message is sent per second?
Please somebody advice.
The text was updated successfully, but these errors were encountered: