Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in StrechFillRect transform invocation #80

Open
franzdevel opened this issue Mar 14, 2017 · 2 comments
Open

Bug in StrechFillRect transform invocation #80

franzdevel opened this issue Mar 14, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@franzdevel
Copy link

It seems that the parameters in Graphic.Transform have been accidentally swapped. The code reads:

public Transform Transform {
  get {
    return Transform.StretchFillRect (ViewBox, new Rect (Point.Zero, Size));
  }
}

but should be:

public Transform Transform {
  get {
    return Transform.StretchFillRect (new Rect (Point.Zero, Size), ViewBox);
  }
}

As a result, the canvas transformation applied by Graphic.Draw (which takes into account the Graphic.ViewBox) does not work correctly.

@praeclarum
Copy link
Owner

Ahhh, thank you. I need to write a test for this.

@praeclarum praeclarum self-assigned this Jul 12, 2017
@praeclarum praeclarum added the bug label Jul 12, 2017
@praeclarum praeclarum added this to the v0.5 milestone Jul 12, 2017
@praeclarum
Copy link
Owner

I'm not so sure if the parameters are backwards. Can you provide a test for this?

@praeclarum praeclarum added invalid and removed bug labels Jul 13, 2017
@praeclarum praeclarum modified the milestones: vNext, v0.5 Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants