Underlining in syntax higlighting of code-blocks in dark mode

[MiroPalmu]

Hi

Is it intended that with default options syntax highlighting for class names contains underlining in dark mode? I'm asking because underscores will overlap with this underlining. Example:

.. code-block:: cpp

   class some_class_name_with_underscores{};

[dgw]

I believe that just means the default Pygments theme(s) contains the underline, and Furo doesn't override the Pygments default. You believe wrong, past-me! Furo sets the default pygments_dark_style, because that's a setting that Furo invented.

The underlining in odd places might be one reason we changed our Sphinx config for [a project I won't self-promote] to explicitly use the "friendly" theme for light mode and "monokai" for dark, besides liking the colors better.

Furo changing this would kind of surprise me, since it's not actually a Furo default but a Pygments default causing it.

[MiroPalmu]

Ok. Thanks for the tip. For reference here is documentation for how to change it, and here is list of builtin styles in Pygments.

Furo doesn't override the Pygments default.

I'm new to using Furo so this might be wrong, but it seems that it's at least doing something since:

[dgw]

Huh, I stand corrected. Furo sets "native" as the default dark-mode code theme, and that's where the underline comes from.

furo/src/furo/__init__.py

Lines 376 to 378 in d14286c

	app.add_config_value(
	"pygments_dark_style", default="native", rebuild="env", types=[str]
	)

And pygments_dark_style isn't a default option in Sphinx, either:

furo/docs/changelog.md

Line 368 in d14286c

- Add (custom) support for `pygments_dark_style`.

So I must apologize. This particular style (the dark mode highlighting) is a Furo default that could be changed!