Fix for inf error when no ignition found #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd. Changed corresponding warning message.
|
Thanks @vayner-s, for some reason it looks like the tests are failing with Python 3.6, due to a different average error value. Could the NaN behavior be affecting this somehow? |
|
For reference, this closes #18 |
|
and closes #1 |
This was
linked to
issues
Apr 6, 2021
|
Yeah, I'm not sure because I tried running the example model locally with Python 3.6.13 and it seems like I'm getting the 58.882 value with and without the NaN change, so doesn't seem like it causes this. |
rwest
added a commit
that referenced
this pull request
Apr 9, 2021
This unit test is failing on Travis only on Python 3.6 but not Python 3.5 on PR #20, and we can't make sense of why. This is mostly a "no change" pull request to trigger the CI tests, but I added a print(output) statement to help debug.
|
I made Pull request #21 to try to see if (and why) the unit tests fail without this nan change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set simulated ignition delay to nan instead of 0.0 when no ignition is found. This was done so that the datapoint is ignored when calculating the error function for the dataset, rather than having it become inf.