Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplementedError #119

Open
benhoare98 opened this issue Oct 3, 2018 · 3 comments
Open

NotImplementedError #119

benhoare98 opened this issue Oct 3, 2018 · 3 comments

Comments

@benhoare98
Copy link

Issue:
Not sure where the error is coming from

Code sample, preferably able to be copy-pasted and run with no changes

Daley_2008_cyclopentane_phi0.25.zip

Expected behavior

That it validates the ChemKED file without errors

Actual behavior, including any error messages


NotImplementedError Traceback (most recent call last)
in ()
----> 1 ChemKED(path)

PyKED/ChemKED version: 4.1, Python version: 3.6.6

@bryanwweber
Copy link
Member

This is almost certainly because of a validation error because of something wrong in the file. I haven't looked at your sample file, but double check that the mole fractions add up to 1.0, the syntax is all correct, the authors are properly specified and spelled, etc.

@bryanwweber
Copy link
Member

So looking at the file, it seems your mole fractions only sum to .999954, which is most likely the cause of this error. Thank you for reporting it! We definitely need to do a better job actually stating what is wrong...

Also, your chemked-version should be 0.4.1 to match the most recent version that supports all the features you're using here 😄

@benhoare98
Copy link
Author

Thank you for taking a look at it! I appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants