Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable CBMC on self-hosted runner #117

Closed
hanno-becker opened this issue Sep 10, 2024 · 5 comments · Fixed by #154
Closed

Re-enable CBMC on self-hosted runner #117

hanno-becker opened this issue Sep 10, 2024 · 5 comments · Fixed by #154
Labels
enhancement New feature or request

Comments

@hanno-becker
Copy link
Contributor

We're hitting resource limitations for the free Ubuntu runner which makes CBMC fail in CI. #113 disables it for now.

We need to discuss whether it's worth re-enabling it on a self-hosted (EC2) runner.
@hanno-becker hanno-becker added the enhancement New feature or request label Sep 10, 2024
@hanno-becker
Copy link
Contributor Author

The CBMC run itself is quick at the moment, but as I remember the nix build takes quite some time, even though we do use the nix cache.

I'd be inclined to open a PR using a medium-capacity EC2 runner for this, running it a few times to gauge the runtime and cost, and then decide if it's worth it.

@hanno-becker
Copy link
Contributor Author

This is currently blocked on a compilation error on CBMC 6.2.0 on ubuntu-latest aarch64 machines. @rod-chapman This is still open right?

@rod-chapman
Copy link
Contributor

Yes... CBMC team are looking at the build failure on Aarch64 machines...

@hanno-becker
Copy link
Contributor Author

@rod-chapman Is this resolved with CBMC 6.3.1 (#150)?

@hanno-becker
Copy link
Contributor Author

Fixed in https://github.com/pq-code-package/mlkem-c-aarch64/pull/154

@hanno-becker hanno-becker mentioned this issue Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run CBMC on EC2 runner in CI and guard by label pq-code-package/mlkem-native
2 participants
@rod-chapman @hanno-becker