3204 fix the handle of not applicable networkmodification when throwexception boolean is present #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olperr1
requested changes
Feb 4, 2025
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/AbstractDisconnection.java
Outdated
Show resolved
Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/util/ModificationLogs.java
Show resolved
Hide resolved
iidm/iidm-modification/src/test/java/com/powsybl/iidm/modification/SwitchModificationsTest.java
Outdated
Show resolved
Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/PercentChangeLoadModification.java
Outdated
Show resolved
Hide resolved
...fication/src/main/java/com/powsybl/iidm/modification/LoadFlowBasedPhaseShifterOptimizer.java
Outdated
Show resolved
Hide resolved
iidm/iidm-modification/src/main/java/com/powsybl/iidm/modification/PhaseShifterOptimizer.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/modification/topology/ReplaceTeePointByVoltageLevelOnLine.java
Outdated
Show resolved
Hide resolved
cphili
changed the title
cphili
force-pushed
the
3204-fix-the-handle-of-not-applicable-networkmodification-when-throwexception-boolean-is-present
branch
from
1e0f8f5 to
c5f6b5b
Compare
cphili
changed the title
cphili
force-pushed
the
3204-fix-the-handle-of-not-applicable-networkmodification-when-throwexception-boolean-is-present
branch
from
8526da0 to
942758c
Compare
cphili
force-pushed
the
3204-fix-the-handle-of-not-applicable-networkmodification-when-throwexception-boolean-is-present
branch
2 times, most recently
from
6296a23 to
8195040
Compare
olperr1
requested changes
Feb 14, 2025
action-api/src/test/java/com/powsybl/action/ApplyActionToNetworkTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/modification/topology/AbstractCreateConnectableFeederBays.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/powsybl/iidm/modification/topology/AbstractCreateConnectableFeederBays.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/powsybl/iidm/modification/topology/AbstractLineConnectionModification.java
Outdated
Show resolved
Hide resolved
...-modification/src/main/java/com/powsybl/iidm/modification/topology/CreateCouplingDevice.java
Outdated
Show resolved
Hide resolved
...dm-modification/src/test/java/com/powsybl/iidm/modification/NetworkModificationListTest.java
Outdated
Show resolved
Hide resolved
...tion/src/test/java/com/powsybl/iidm/modification/topology/ConnectVoltageLevelOnLineTest.java
Outdated
Show resolved
Hide resolved
...ication/src/test/java/com/powsybl/iidm/modification/topology/CreateBranchFeederBaysTest.java
Outdated
Show resolved
Hide resolved
...ification/src/test/java/com/powsybl/iidm/modification/topology/CreateCouplingDeviceTest.java
Outdated
Show resolved
Hide resolved
...m-modification/src/test/java/com/powsybl/iidm/modification/topology/CreateFeederBayTest.java
Outdated
Show resolved
Hide resolved
cphili
force-pushed
the
3204-fix-the-handle-of-not-applicable-networkmodification-when-throwexception-boolean-is-present
branch
from
dcb25ea to
2508851
Compare
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
cphili
force-pushed
the
3204-fix-the-handle-of-not-applicable-networkmodification-when-throwexception-boolean-is-present
branch
from
2508851 to
e4e90df
Compare
olperr1
requested changes
Feb 17, 2025
...ication/src/test/java/com/powsybl/iidm/modification/VscConverterStationModificationTest.java
Outdated
Show resolved
Hide resolved
...on/src/test/java/com/powsybl/iidm/modification/TestThreeWindingsTransformerModification.java
Outdated
Show resolved
Hide resolved
...ion/src/test/java/com/powsybl/iidm/modification/topology/CreateVoltageLevelTopologyTest.java
Outdated
Show resolved
Hide resolved
...dm-modification/src/test/java/com/powsybl/iidm/modification/tripping/BranchTrippingTest.java
Show resolved
Hide resolved
|
Can you also take a look at the sonar issues? Some can be easily fixed. |
Signed-off-by: Clement Philipot <[email protected]>
Signed-off-by: Clement Philipot <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #3204
What kind of change does this PR introduce?
Call logOrThrow method in NetworkModification::apply implementations
Some NetworkModifications threw an Exception in all cases, now they only throw when throwException is true :
AbstractTripping
CloseSwitch
ConnectGenerator
OpenSwitch
PhaseShifterOptimizeTap
PhaseShifterSetAsFixedTap
PhaseShifterShiftTap
ShuntCompensatorModification
Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Not really a breaking change, but the behavior of some
NetworkModifications was changed by this PR. They threw an Exception when a problem was encountered, even whenthrowExceptionwas set tofalsewhen calling theapply(...)method. They are:<to be completed>Other information: