Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv output #240

Open
thetechfirm opened this issue Oct 6, 2024 · 15 comments
Open

csv output #240

thetechfirm opened this issue Oct 6, 2024 · 15 comments
Labels
feature request feature request good first issue Good for newcomers

Comments

@thetechfirm
Copy link

not sure if i just missed it but I cant find the option to save the output to a CSV format.
if its not there, that feature would be helpful for me.

regards

@pouriyajamshidi
Copy link
Owner

Hi @thetechfirm,

There is no option to output in CSV format yet.

We will see if someone is willing to take this up.

@thetechfirm
Copy link
Author

thetechfirm commented Oct 6, 2024 via email

@pouriyajamshidi
Copy link
Owner

Nice to know about the post!

no worries, probably someone will pick it up if I cannot manage to get to it myself. Life is very busy these days

@thetechfirm
Copy link
Author

thetechfirm commented Oct 6, 2024 via email

@pouriyajamshidi pouriyajamshidi added the feature request feature request label Oct 12, 2024
@pouriyajamshidi pouriyajamshidi moved this to Todo in TCPING Oct 12, 2024
@pouriyajamshidi pouriyajamshidi added the good first issue Good for newcomers label Oct 18, 2024
@SYSHIL
Copy link
Contributor

SYSHIL commented Oct 19, 2024

Hii @pouriyajamshidi Shall I pick this up?

@pouriyajamshidi
Copy link
Owner

Hi @SYSHIL,

Hope you are well.

Sure, please go ahead.

@SYSHIL
Copy link
Contributor

SYSHIL commented Oct 20, 2024

I'm doing good @pouriyajamshidi, hope you are too :)

There is no option to output in CSV format yet.

We can either treat this as a separate printer like our DB printer or JSON printer or we let this saveToCSV option co-exist with the existing behaviour. in my opinion a separate printer looks neater what do you think?

@pouriyajamshidi
Copy link
Owner

I'm doing good @pouriyajamshidi, hope you are too :)

There is no option to output in CSV format yet.

We can either treat this as a separate printer like our DB printer or JSON printer or we let this saveToCSV option co-exist with the existing behaviour. in my opinion a separate printer looks neater what do you think?

I am also doing fine man, thank you.

yes, a separate printer sounds more logical.

@thetechfirm
Copy link
Author

thetechfirm commented Oct 20, 2024 via email

@thetechfirm
Copy link
Author

thetechfirm commented Oct 20, 2024 via email

@SYSHIL SYSHIL mentioned this issue Oct 27, 2024
7 tasks
@SYSHIL
Copy link
Contributor

SYSHIL commented Nov 26, 2024

Hi @thetechfirm
I have a question...how do you think we should handle statistics output we now get in the terminal while working with csv files?

I see two options,

  1. We pipe the statistics output to a separate csv file with a different schema compared to the csv file we'll send our terminal output to
  2. Ignore printing statistics in we're recording the output in csv format.

I'm leaning towards option 2 but I would love to hear your thoughts on this :)

@thetechfirm
Copy link
Author

thetechfirm commented Nov 26, 2024 via email

@pouriyajamshidi
Copy link
Owner

Hey @thetechfirm, Good news!

The CSV PR is merged now.

I am planning to have a release by mid Jan after some minor changes to the code base (not necessarily CSV related).

Another option (--no-color) next to CSV output is also added which you can benefit from while redirecting output to a file. This way the ANSI control characters will not be written in the file.

Of course, if you are an early adopter, feel free to compile from source and use it like that till the official release.

@thetechfirm
Copy link
Author

thetechfirm commented Dec 23, 2024 via email

@pouriyajamshidi
Copy link
Owner

Thank you so much, @thetechfirm

Merry Christmas to you and your family too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants