Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Establish minimum version when liquid-dsp exit() calls removed #11

Open
ncorgan opened this issue Aug 2, 2020 · 1 comment
Open

Establish minimum version when liquid-dsp exit() calls removed #11

ncorgan opened this issue Aug 2, 2020 · 1 comment
Assignees
@ncorgan

Comments

@ncorgan
Copy link
Member

ncorgan commented Aug 2, 2020

Currently, liquid-dsp calls exit() when certain input validations fail, and PothosLiquidDSP can trigger these, as it does not perform its own input validation. When this bug is fixed, the next PothosLiquidDSP version should establish a minimum version to prevent running into this.

Relevant issue here: jgaeddert/liquid-dsp#134
@ncorgan ncorgan self-assigned this Aug 2, 2020
@ncorgan
Copy link
Member Author

ncorgan commented Dec 5, 2020

99bdc92

This allows compilation with LiquidDSP versions before and after the exit() fix, but the auto-generated blocks don't do anything with the return code. This can probably be done by tweaking the mako templates, but the issue still stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncorgan ncorgan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ncorgan