Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intended "Getter" Behavior When Used with Ember-Data Model ? #665

Open
kdagnan opened this issue Mar 1, 2023 · 0 comments
Open

Intended "Getter" Behavior When Used with Ember-Data Model ? #665

kdagnan opened this issue Mar 1, 2023 · 0 comments

Comments

@kdagnan
Copy link

kdagnan commented Mar 1, 2023

Hi,

I have 2 applications, old and new.

Old:

  • Running Ember 3.20.2, Ember-Data 3.20.x, and Ember-Changeset 2.2.4
  • Ember-Data models are still defined with 'classic' syntax (ie. Model.extend and computed properties)

New:

  • Running ember 3.28.x, ember-data 3.28.x and Ember-Changeset 4.1.x
  • Ember-Data models are defined in 'octane' syntax (ie. class Example extends Model and get property() )

When I create a changeset from the respective ember-data models, is the below behavior expected?

Old: changeset.get('computedProperty') is always valid based on changeset.get('dependency') value
New: changeset.getterProperty is not updated when changeset.dependency is updated, only when changeset.save() persists the changes to the ember-data model

Is this because I'm not using .get() and .set() in new?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant