Did not handle invalid input for fields in filter

[potaotototo]

Problem

When user input an invalid field for filter, there isn't any error messages warning the user.

Steps to reproduce

filter m/m

Expected

Error: the module m does not exist.

Actual

0 persons listed!

Screenshot

Potential improvement

add error message

[nus-pe-bot]

Team's Response

The example you gave was filter a person with module m, and this did not match any existing records, the system correctly indicated that 0 person listed!. This is a valid outcome as the filter simply narrow down the list based on the given input, regardless of whether the input matches existing data.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: 0 persons listed! is not a sufficiently specific error message especially given that your filter feature implements an AND search with multiple possible fields:

If the user wants to filter with multiple fields but enters an invalid field e.g. Emath not Mathematics, they can mistakenly believe that there is no such student, while in reality it is 0 persons listed! because no such module / tag / phone number / name exists (could be caused by a minor typo on the user's end e.g. Jin Xiang instead of Jing Xiang).

Furthermore, since your find does not support finding by module, it is better if you give specific error message as to why there isn't any match. I would like to believe this should be more of an out of scope rather than a reject.

---