Skip to content

Commit 4fa701c

Browse files
committed
fixup! Fix NTLM auth state when iterations are more than 3
1 parent 58fe97b commit 4fa701c

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

lib/runner/extensions/item.command.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,7 @@ module.exports = {
188188

189189
var request = result.request,
190190
response = result.response,
191-
cookies = result.cookies,
192-
auth = result.item.getAuth();
191+
cookies = result.cookies;
193192

194193
if ((stopOnError || stopOnFailure) && requestError) {
195194
this.triggers.item(null, coords, item); // @todo - should this trigger receive error?
@@ -212,11 +211,6 @@ module.exports = {
212211
// set cookies for this transaction
213212
cookies && (ctxTemplate.cookies = cookies);
214213

215-
// update the item auth to prevent loss of auth state
216-
// @note this is a hack because the auth architecture is messy, and there is some confusion
217-
// between `originalItem` and `item`.
218-
auth && (item.auth = auth);
219-
220214
// the context template also has a test object to store assertions
221215
ctxTemplate.tests = {}; // @todo remove
222216

lib/runner/replay-controller.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
var _ = require('lodash'),
2-
createItemContext = require('./create-item-context'),
32

43
// total number of replays allowed
54
MAX_REPLAY_COUNT = 3,
@@ -51,8 +50,7 @@ _.assign(ReplayController.prototype, /** @lends ReplayController.prototype */{
5150
abortOnError: true
5251
}, desiredPayload);
5352

54-
// create item context from the new item
55-
payload.context = createItemContext(payload, context);
53+
payload.context = context;
5654

5755
this.run.immediate('httprequest', payload)
5856
.done(function (response) {

0 commit comments

Comments
 (0)