Skip to content

Commit 89bea8d

Browse files
committed
Remove latest activity column (#49)
Having both "Latest email" and "Latest activity" as a column on the commitfest page is kind of useless. The "Latest activity" often is simply the date that a patch was moved to the next commitfest, so it's content is rather useless in general. If we improve the commitfest app to contain more useful info, then it might become more useful to have this timestamp. For now it seems fine to remove it though. We can always add it back later if it turns out that people miss it. Fixes #21
1 parent 40cb26c commit 89bea8d

File tree

2 files changed

+1
-7
lines changed

2 files changed

+1
-7
lines changed

pgcommitfest/commitfest/templates/commitfest.html

-2
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ <h3>{{p.is_open|yesno:"Active patches,Closed patches"}}</h3>
7070
<th>Reviewers</th>
7171
<th>Committer</th>
7272
<th><a href="#" style="color:#333333;" onclick="return sortpatches(3);">Num cfs</a>{%if sortkey == 3%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%elif sortkey == -3%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-up"></i></div>{%endif%}</th>
73-
<th><a href="#" style="color:#333333;" onclick="return sortpatches(1);">Latest activity</a>{%if sortkey == 1%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%elif sortkey == -1%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-up"></i></div>{%endif%}</th>
7473
<th><a href="#" style="color:#333333;" onclick="return sortpatches(2);">Latest mail</a>{%if sortkey == 2%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-down"></i></div>{%elif sortkey == -2%}<div style="float:right;"><i class="glyphicon glyphicon-arrow-up"></i></div>{%endif%}</th>
7574
{%if user.is_staff%}
7675
<th>Select</th>
@@ -125,7 +124,6 @@ <h3>{{p.is_open|yesno:"Active patches,Closed patches"}}</h3>
125124
<td>{{p.reviewer_names|default:''}}</td>
126125
<td>{{p.committer|default:''}}</td>
127126
<td>{{p.num_cfs}}</td>
128-
<td style="white-space: nowrap;">{{p.modified|date:"Y-m-d"}}<br/>{{p.modified|date:"H:i"}}</td>
129127
<td style="white-space: nowrap;">{{p.lastmail|date:"Y-m-d"}}<br/>{{p.lastmail|date:"H:i"}}</td>
130128
{%if user.is_staff%}
131129
<td style="white-space: nowrap;"><input type="checkbox" class="sender_checkbox" id="send_authors_{{p.id}}">Author<br/><input type="checkbox" class="sender_checkbox" id="send_reviewers_{{p.id}}">Reviewer</td>

pgcommitfest/commitfest/views.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,7 @@ def commitfest(request, cfid):
239239
except ValueError:
240240
sortkey = 0
241241

242-
if sortkey == 1:
243-
orderby_str = "modified, created"
244-
elif sortkey == -1:
245-
orderby_str = "modified DESC, created DESC"
246-
elif sortkey == 2:
242+
if sortkey == 2:
247243
orderby_str = "lastmail, created"
248244
elif sortkey == -2:
249245
orderby_str = "lastmail DESC, created DESC"

0 commit comments

Comments
 (0)