invalid URLs to download forms

[danbjoseph]

form_id versus the file name seems to be causing issues. the link to download a form through the main interface appears to be using the form_id to build the download url, whereas the filename is what needs to be used (i.e. in the screen shots for the example shown below it should be http://omkserver.com/omk/data/forms/africa_schools.xlsx and not http://omkserver.com/omk/data/forms/schools.xlsx). not sure what other implications this might have in terms of form listing when downloading, preventing accidental overwrites, etc. i've seen plenty of times in the past when someone will update a filename for a new version of a form but will leave the meta-data defined within the form the same.

• the main interface

- the url when you click the download the xls

- the form file

[hallahan]

The issue isn't really a form name / form_id discrepancy. Actually, it's a file name / form_id discrepancy.

When an XLSX file is uploaded, we should take a look at the actual form ID and write the file as that. The user should be notified of that rewrite. For now, make sure you name your xlsx file the same thing as your form_id.

[hallahan]

I'd say we really want a tiny little node module that checks these things:

• Is the form id already on the server?
• Is the file name the same?
• Notify the user about this and what we did about it?
• Ask if we want to overwrite the existing form or make a new one with a number at the end?

This issue is in the wrong repo: should be https://github.com/AmericanRedCross/OpenMapKitServer/issues

Solving this would resolve #53