#122 #129 #137 - Does not re-instantiate a Deployment each time we get a new list from ExternalStorage or the server.

Author: hallahan

app/src/main/java/org/redcross/openmapkit/deployments/Deployments.java

@@ -55,10 +55,16 @@ private void putDeployment(JSONObject deploymentJson) {
             nameToIdx.put(name, deployments.size());
             deployments.add(deployment);
         }
+
+        /**
+         * Note: Needs Server Synchronization
+         *
+         * https://github.com/AmericanRedCross/OpenMapKitAndroid/issues/137
+         */
         // replace existing deployment
-        else {
-            deployments.set(idx, deployment);
-        }
+//        else {
+//            deployments.set(idx, deployment);
+//        }
     }
 
     public void fetch(DeploymentsActivity activity, String url) {
@@ -110,8 +116,6 @@ private void parseJsonFromApi(String json) {
      */
     private Deployments.Status fetchFromExternalStorage() {
         Deployments.Status status = Status.SERVER_NOT_FOUND;
-        deployments.clear();
-        nameToIdx.clear();
         List<File> files = ExternalStorage.allDeploymentJSONFiles();
         for (File f : files) {
             try {