Windows compatibility issue

[mischakolbe]

Are these fancier start/build/test scripts in the package.json required?

...
  "scripts": {
    "start": "REACT_APP_COMMIT_HASH=$(git rev-parse HEAD) react-scripts start",
    "build": "REACT_APP_COMMIT_HASH=$(git rev-parse HEAD) react-scripts build",
    "test": "REACT_APP_COMMIT_HASH=$(git rev-parse HEAD) react-scripts test",
    ...

I got errors on Windows (terminal, bash & powershell) and a hacky equivalent probably doesn't work on Mac...

...
  "scripts": {
    "start": "git rev-parse HEAD >sha.txt && set /p REACT_APP_COMMIT_HASH= < sha.txt && del sha.txt && react-scripts start",
    "build": "git rev-parse HEAD >sha.txt && set /p REACT_APP_COMMIT_HASH= < sha.txt && del sha.txt && react-scripts build",
    "test": "git rev-parse HEAD >sha.txt && set /p REACT_APP_COMMIT_HASH= < sha.txt && del sha.txt && react-scripts test",
    ...

I don't think the commit hash is very necessary and we could just switch to this?

...
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    ...

[mAkeddar]

Yep the original file for scripts is this one
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
}

The app launch doesn't depend on the hash, right @hugo2410 ?

[hugo2410]

@mAkeddar @mischakolbe having the git hash before building allows us to have for every single build. So, we are sure that even if we get the versioning wrong (as it is done manually) we are able to trace back to the specific version of the code. It would allow us to debug easier. I can try and investigate how we need to adapt the path to make it work cross-platform

[mischakolbe]

Fair point, Hugo. Good to know! If it gets embedded into the build to make it reproducible it's another story. At first glance it looked like it was just for a printout when running npm start.

…

On Mon, Jun 12, 2023, 18:06 Hugo Birch ***@***.***> wrote: @mAkeddar <https://github.com/mAkeddar> @mischakolbe <https://github.com/mischakolbe> having the git hash before building allows us to have for every single build. So, we are sure that even if we get the versioning wrong (as it is done manually) we are able to trace back to the specific version of the code. It would allow us to debug easier. I can try and investigate how we need to adapt the path to make it work cross-platform — Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFZO2XK7HGHJVWTPN3EQXZDXK447NANCNFSM6AAAAAAZCUGER4> . You are receiving this because you were mentioned.Message ID: ***@***.***>