Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will there be a build for Apple silicon chip? #2664

Closed
samxl001 opened this issue Nov 30, 2022 · 3 comments
Closed

Will there be a build for Apple silicon chip? #2664

samxl001 opened this issue Nov 30, 2022 · 3 comments

Comments

@samxl001
Copy link

Hi, I am using the latest version of Popcorntime on my Macbook air M1 which is run through rosetta. It runs fine but sometimes it crashes repeatedly. I don't know if the crash is due to njws or rosetta. Will there be a build for Apple silicon chips (M1, M2, etc.)?

@bouachalazhar
Copy link

bouachalazhar commented Jan 8, 2023

When I build with yarn build :

yarn build
yarn run v1.22.19
$ gulp build
(node:4309) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(Use node --trace-warnings ... to show where the warning was created)
(node:4309) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:4309) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:4309) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:4309) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:4309) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
Error: No platform to build!
    at new NwBuilder (/usr/local/Homebrew/Library/Taps/popcorn-official/homebrew-popcorn-desktop/node_modules/nw-builder/lib/index.cjs:94:11)
    at Object.<anonymous> (/usr/local/Homebrew/Library/Taps/popcorn-official/homebrew-popcorn-desktop/gulpfile.js:171:12)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at Module.load (node:internal/modules/cjs/loader:1081:32)
    at Module._load (node:internal/modules/cjs/loader:922:12)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at requireOrImport (/usr/local/Homebrew/Library/Taps/popcorn-official/homebrew-popcorn-desktop/node_modules/gulp-cli/lib/shared/require-or-import.js:19:11)
    at execute (/usr/local/Homebrew/Library/Taps/popcorn-official/homebrew-popcorn-desktop/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How install in M2 ?

@ChristianF88
Copy link

Hi there, same problem here. I have a Macbook Air with an M2 chip in it. When I try building with yarn:

git clone https://github.com/popcorn-official/popcorn-desktop.git 
cd popcorn-desktop
yarn install
➜  popcorn-desktop git:(development) sh make_popcorn.sh
You appear to be inside of a Popcorn Time repository already, not cloning
Switched to /Users/hildi/repos/popcorn-desktop
yarn run v1.22.19
$ gulp build
(node:16831) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:16831) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
Error: No platform to build!
    at new NwBuilder (/Users/hildi/repos/popcorn-desktop/node_modules/nw-builder/lib/index.cjs:94:11)
    at Object.<anonymous> (/Users/hildi/repos/popcorn-desktop/gulpfile.js:171:12)
    at Module._compile (node:internal/modules/cjs/loader:1275:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1329:10)
    at Module.load (node:internal/modules/cjs/loader:1133:32)
    at Module._load (node:internal/modules/cjs/loader:972:12)
    at Module.require (node:internal/modules/cjs/loader:1157:19)
    at require (node:internal/modules/helpers:119:18)
    at requireOrImport (/Users/hildi/repos/popcorn-desktop/node_modules/gulp-cli/lib/shared/require-or-import.js:19:11)
    at execute (/Users/hildi/repos/popcorn-desktop/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Popcorn Time encountered an error and couldn't be built

I also tried the install via homebrew:

➜  popcorn-desktop git:(development) brew tap popcorn-official/popcorn-desktop https://github.com/popcorn-official/popcorn-desktop.git
#export HOMEBREW_POPCORN_TIME_BUILD=false
brew install --cask popcorn-time #--no-quarantine
==> Downloading https://formulae.brew.sh/api/cask.json

==> Downloading https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases/download/0.64.0/0.64.0-osx-x64.zip
Already downloaded: /Users/hildi/Library/Caches/Homebrew/downloads/b4d98f1f431841ecd31529ae752965bb1953c21e3683590c3fc316ce84937f8a--0.64.0-osx-x64.zip
Error: Cask popcorn-time depends on hardware architecture being one of [{:type=>:intel, :bits=>64}], but you are running {:type=>:arm, :bits=>64}.
➜  popcorn-desktop git:(development)

@bouachalazhar
Copy link

Hi there, same problem here. I have a Macbook Air with an M2 chip in it. When I try building with yarn:

git clone https://github.com/popcorn-official/popcorn-desktop.git 
cd popcorn-desktop
yarn install
➜  popcorn-desktop git:(development) sh make_popcorn.sh
You appear to be inside of a Popcorn Time repository already, not cloning
Switched to /Users/hildi/repos/popcorn-desktop
yarn run v1.22.19
$ gulp build
(node:16831) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:16831) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:16831) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
Error: No platform to build!
    at new NwBuilder (/Users/hildi/repos/popcorn-desktop/node_modules/nw-builder/lib/index.cjs:94:11)
    at Object.<anonymous> (/Users/hildi/repos/popcorn-desktop/gulpfile.js:171:12)
    at Module._compile (node:internal/modules/cjs/loader:1275:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1329:10)
    at Module.load (node:internal/modules/cjs/loader:1133:32)
    at Module._load (node:internal/modules/cjs/loader:972:12)
    at Module.require (node:internal/modules/cjs/loader:1157:19)
    at require (node:internal/modules/helpers:119:18)
    at requireOrImport (/Users/hildi/repos/popcorn-desktop/node_modules/gulp-cli/lib/shared/require-or-import.js:19:11)
    at execute (/Users/hildi/repos/popcorn-desktop/node_modules/gulp-cli/lib/versioned/^4.0.0/index.js:37:3)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Popcorn Time encountered an error and couldn't be built

I also tried the install via homebrew:

➜  popcorn-desktop git:(development) brew tap popcorn-official/popcorn-desktop https://github.com/popcorn-official/popcorn-desktop.git
#export HOMEBREW_POPCORN_TIME_BUILD=false
brew install --cask popcorn-time #--no-quarantine
==> Downloading https://formulae.brew.sh/api/cask.json

==> Downloading https://github.com/iteufel/nwjs-ffmpeg-prebuilt/releases/download/0.64.0/0.64.0-osx-x64.zip
Already downloaded: /Users/hildi/Library/Caches/Homebrew/downloads/b4d98f1f431841ecd31529ae752965bb1953c21e3683590c3fc316ce84937f8a--0.64.0-osx-x64.zip
Error: Cask popcorn-time depends on hardware architecture being one of [{:type=>:intel, :bits=>64}], but you are running {:type=>:arm, :bits=>64}.
➜  popcorn-desktop git:(development)

If you resolve it send me. I can help you if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants