Dialogs switch the stack to an incorrect window

[sitepodmatt]

(1) Issue/Bug Description
When using window stacking, popos changes active stack window when a IntelliJ IDEA based product in a stack application launches a dialog (such as Settings)

(2) Steps to reproduce (if you know):

Create a popos stack
Add a Jetbrain's IntelliJ IDEA (could also be a variant such as WebStorm, Rider, CLion, PyCharm, PhpStorm or RubyMine, DataGrip, AppCode or Android Studio)
Add another app such as Firefox.
Do an action that launches a dialog from the IntelliJ such as opening settings (File -> Settings) popos shell needlessly switches the stack to the wrong window.

(3) Expected behavior: No switching of my stack

(4) Distribution (run cat /etc/os-release): Pop!_OS 20.10

(5) Gnome Shell version: 3.38.1

(6) Pop Shell version (run apt policy pop-shell or provide the latest commit if building locally):

1.0.0160468824220.10~d1d2b0e

(7) Where was Pop Shell installed from: apt-get install popos-desktop

I found this #407 but it doesn't explain why the stack is changing active window, unless it's expecting the dialog to open as part of the stack and trying to focus it but it isn't there??

Perhaps it should only refocus the stack if a window is actually added to the stack, as the modal appears correctly in all other manners?

[sitepodmatt]

tl;dr popos is changing window the active window in the stack when it shouldnt - i got automatically switched to the browser here by just triggering a rename dialog in intellij. Oddly PopOS shell switches back to the correct window once I've completed the action so more annoying at this stage than anything else

[sitepodmatt]

NAME="Pop!_OS"
VERSION="20.10"
ID=pop
ID_LIKE="ubuntu debian"
PRETTY_NAME="Pop!_OS 20.10"
VERSION_ID="20.10"
HOME_URL="https://pop.system76.com"
SUPPORT_URL="https://support.system76.com"
BUG_REPORT_URL="https://github.com/pop-os/pop/issues"
PRIVACY_POLICY_URL="https://system76.com/privacy"
VERSION_CODENAME=groovy
UBUNTU_CODENAME=groovy
LOGO=distributor-logo-pop-os

[mmstick]

Dialogs aren't permitted to tile, so something else is happening. I've been looking into this

[sitepodmatt]

Thanks. I've updated the bug description tl;dr - easier to replicate via just opening settings rather than trying to get a rename window going.

[sitepodmatt]

Was this fixed by 2a3560a?

[sitepodmatt]

Just tried with latest verison, still busted, in stacking mode, opening a dialog like rename variable (shift+f6) switches the stack window

[sitepodmatt]

Just to update replication instructions on latest, renaming has become inline in many Jetbrains IDEs, ill choose most popular IntelliJ, so stacking setup with three windows (ff, intellij, terminal), so easiest way now is to shift twice in quick succession (brings up the All tasks selector), and choose the first option for example (Analyse Stack trace or thread dump), pop os gets confused and focuses the nth window in the stack (the terminal) whilst this dialog is showing, and back to nth-1 (the middle - intellij ) after closing..

[sitepodmatt]

To be clear, this is not a problem in i3wm on the same popos distro (and thus same intellij), and seems to only happen in stacking mode

[hoshsadiq]

Hello all, I have the same issue. I don't know much about the inner workings here but it looks to me like an off by one index somewhere. It seems to always switch to the last window I have selected, i.e. if I Firefox, Spotify, IntelliJ, if I open Firefox, then IntelliJ, then open a dialog, it shows Firefox, however, if I open Spotify, then IntelliJ, dialogs switch to Spotify.

Also, dragging editor windows also causes this, which makes dropping windows extremely hard.

[sitepodmatt]

Yes, I initially thought it off by one too, I think it's expecting the dialog to be part of the stack and then it tries to switch to it but that exceeds the number of windows in the stack so either lands on the next one or back at 0

@mmstick would any diagnosis material help on this? a video via dropbox for example?

[sitepodmatt]

Could this be related to having _NET_WM_STATE_SKIP_TASKBAR?

WM_STATE(WM_STATE):
window state: Normal
icon window: 0x0
_NET_WM_DESKTOP(CARDINAL) = 0
_GTK_EDGE_CONSTRAINTS(CARDINAL) = 170
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
_NET_WM_STATE(ATOM) = _NET_WM_STATE_SKIP_PAGER, _NET_WM_STATE_SKIP_TASKBAR
WM_HINTS(WM_HINTS):
Client accepts input or input focus: True
Initial state is Normal State.
bitmap id # to use for icon: 0x8c00007
bitmap id # of mask for icon: 0x8c00012
window id # of group leader: 0x8c00001
_GTK_THEME_VARIANT(UTF8_STRING) =
XdndAware(ATOM) = BITMAP
_NET_WM_STATE(ATOM) = _NET_WM_STATE_SKIP_TASKBAR
WM_HINTS(WM_HINTS):
Client accepts input or input focus: False
window id # of group leader: 0x4c00089
WM_TRANSIENT_FOR(WINDOW): window id # 0x4c00089
_NET_WM_PID(CARDINAL) = 54328
WM_CLIENT_MACHINE(STRING) = "asus36"
WM_PROTOCOLS(ATOM): protocols WM_DELETE_WINDOW, WM_TAKE_FOCUS
WM_NAME(STRING) = "Settings"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
user specified location: 609, 27
program specified location: 609, 27
program specified size: 992 by 952
program specified minimum size: 900 by 700
window gravity: NorthWest

[sitepodmatt]

This is still happening in the latest dev branch, although not as much.

activate is getting called in stack.ts, and then usually the first window is getting selected due to Ecs.entity_eq(entity, component.entity) returning true. There are times I can't replicate this though now until I select a different window in stack and then switch back to IntelliJ then it's replicatable again. Will try and do some more exhuastive debugging

[sitepodmatt]

1616834689767=== activate called ==
ist :false
ist :activate@/home/matt/.local/share/gnome-shell/extensions/pop-shell@system76.com/stack.js:79:31
on_focused@/home/matt/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:490:197
signals_attach/</<@/home/matt/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:1319:26

ist2:false
1616834689779=== activate called ==
ist :false
ist :activate@/home/matt/.local/share/gnome-shell/extensions/pop-shell@system76.com/stack.js:79:31
on_focused@/home/matt/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:490:197
signals_attach/</<@/home/matt/.local/share/gnome-shell/extensions/pop-shell@system76.com/extension.js:1319:26

Here how activate is being called... seem to come from focus

[sitepodmatt]

    focus_window(): Window.ShellWindow | null {
        let focused = this.get_window(display.get_focus_window())
        //if (!focused && this.last_focused) {
        //    focused = this.windows.get(this.last_focused);
        //}
        return focused;
    }

Okay managed to get this solved for my use case, but unsure what other problems I've introduced here by simply commenting out.