-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move typescript and viem to peer dependencies #420
Conversation
This PR was not deployed automatically as @kyscott18 does not have access to the Railway project. In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions
@@ -62,7 +66,6 @@ | |||
"react": "^18.2.0", | |||
"retry": "^0.13.1", | |||
"stacktrace-parser": "^0.1.10", | |||
"viem": "^1.18.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still wrapping my head around peer dependencies. But, don't we need viem
as a full dep? The interaction between @ponder/core
and viem
is not just in the user repository; it's also in @ponder/core
itself? Genuinely not sure lol.
@@ -82,7 +85,6 @@ | |||
"rimraf": "^5.0.5", | |||
"supertest": "^6.3.3", | |||
"tsc-alias": "^1.8.8", | |||
"typescript": "^5.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the wagmi package.json still likes typescript
(and viem
) in dev deps. Not sure of the interaction between dev and peer deps but thought I'd mention. https://www.npmjs.com/package/wagmi?activeTab=code
No description provided.