Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typescript and viem to peer dependencies #420

Closed
wants to merge 9 commits into from
Closed

Conversation

kyscott18
Copy link
Collaborator

No description provided.

Copy link

railway-app bot commented Nov 10, 2023

This PR was not deployed automatically as @kyscott18 does not have access to the Railway project.

In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page.

Copy link

changeset-bot bot commented Nov 10, 2023

⚠️ No Changeset found

Latest commit: d8cdaa8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 6:15pm

Copy link
Collaborator

@0xOlias 0xOlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions

@@ -62,7 +66,6 @@
"react": "^18.2.0",
"retry": "^0.13.1",
"stacktrace-parser": "^0.1.10",
"viem": "^1.18.9",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still wrapping my head around peer dependencies. But, don't we need viem as a full dep? The interaction between @ponder/core and viem is not just in the user repository; it's also in @ponder/core itself? Genuinely not sure lol.

@@ -82,7 +85,6 @@
"rimraf": "^5.0.5",
"supertest": "^6.3.3",
"tsc-alias": "^1.8.8",
"typescript": "^5.2.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the wagmi package.json still likes typescript (and viem) in dev deps. Not sure of the interaction between dev and peer deps but thought I'd mention. https://www.npmjs.com/package/wagmi?activeTab=code

@kyscott18 kyscott18 closed this Nov 13, 2023
@kyscott18 kyscott18 deleted the peer-deps branch November 15, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants