Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in example repos #418

Merged
merged 14 commits into from
Nov 10, 2023
Merged

Fix bugs in example repos #418

merged 14 commits into from
Nov 10, 2023

Conversation

kyscott18
Copy link
Collaborator

Fix small bugs in example repos that occurred as a result of recent rapid changes. Also fixes linting.

Copy link

railway-app bot commented Nov 10, 2023

This PR was not deployed automatically as @kyscott18 does not have access to the Railway project.

In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page.

Copy link

changeset-bot bot commented Nov 10, 2023

⚠️ No Changeset found

Latest commit: 04fda99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ponder-docs ✅ Ready (Inspect) Visit Preview Nov 10, 2023 4:57pm

@@ -3,4 +3,5 @@ node_modules/

.env.local
.ponder/
generated/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to convert all the examples to use the .gitignore that I pasted into the create-ponder script

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your example .gitignore doesn't include .ponder

Comment on lines +26 to +31
contents: await context.client.readContract({
abi: FileStoreFrontendAbi,
functionName: "readFile",
address: "0xBc66C61BCF49Cc3fe4E321aeCEa307F61EC57C0b",
args: [event.transaction.to!, filename],
}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this works!! Seems like a fair enough pattern.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gets tough when you want to use multichain but I wanted to get this moving.

@kyscott18 kyscott18 merged commit df46c1b into main Nov 10, 2023
7 of 9 checks passed
@kyscott18 kyscott18 deleted the kjs/examples-bugs branch November 10, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants