-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in example repos #418
Conversation
This PR was not deployed automatically as @kyscott18 does not have access to the Railway project. In order to get automatic PR deploys, please add @kyscott18 to the project inside the project settings page. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -3,4 +3,5 @@ node_modules/ | |||
|
|||
.env.local | |||
.ponder/ | |||
generated/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to convert all the examples to use the .gitignore that I pasted into the create-ponder script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your example .gitignore doesn't include .ponder
contents: await context.client.readContract({ | ||
abi: FileStoreFrontendAbi, | ||
functionName: "readFile", | ||
address: "0xBc66C61BCF49Cc3fe4E321aeCEa307F61EC57C0b", | ||
args: [event.transaction.to!, filename], | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this works!! Seems like a fair enough pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gets tough when you want to use multichain but I wanted to get this moving.
Fix small bugs in example repos that occurred as a result of recent rapid changes. Also fixes linting.