-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC721 example app #230
Conversation
🦋 Changeset detectedLatest commit: 0079b4e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks, I noticed as well and I couldn't tell where this was used in the codebase and seemed to be stored for history. I patched my local version to make the database field nullable and things were working as expected. |
Ah, makes sense. While we're here - any other patches you had to make? FYI, the reason we store |
I haven't got it tested yet, waiting on historical sync. But I exposed the |
This PR adds an ERC271 example app for the Smol Brains NFT collection on Arbitrum. I also noticed some RPC provider inconsistencies while testing this out. Specifically, Alchemy seems to rename
transaction.type
totransaction.arbType
for some bizarre reason. Quicknode works as expected.I've ran into enough issues related to this specific field that it may be worth making it nullable in the database, but for now I added a default of
"0x0"
so that Alchemy still works.Also fixed a bug where
block.baseFeePerGas
was (wrongly) assumed to be non-null when formatting event objects coming out of the event store.