Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add case insensitive alternatives for string filter options #870

Open
4 tasks
0xOlias opened this issue May 8, 2024 · 0 comments
Open
4 tasks

Comments

@0xOlias
Copy link
Collaborator

0xOlias commented May 8, 2024

The filter API for findMany and plural GraphQL fields (documented here) does not currently support case insensitive filtering for string column types. This is a relatively popular feature in subgraphs, often used to support search, so we should add it.

It would apply to contains, starts_with, and ends_with, and their not variants. In total, we'd have to add 6 options.

Checklist:

  • Research case sensitive/insensitive comparisons in both SQLite and Postgres to determine if this is feasible, also keeping in mind index coverage
  • Add new options to src/indexing-store/utils/filter.ts and tests
  • Add tests in src/indexing-store/readonly.test.ts
  • Update docs + write changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant