Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Travis-CI no longer tests the integration of PRs (commit f004f9c) #118

Closed
Hacklin opened this issue Jun 6, 2018 · 3 comments
Closed

Comments

@Hacklin
Copy link
Contributor

Hacklin commented Jun 6, 2018

BUG: Travis-CI no longer tests the integration of Pull Request or any other branch except for master!
(Due to commit f004f9c)

Commit f004f9c hijacked Travis-CI to build a Docker executable from git master.
Travis-CI should be used to test the integration of any changes to the source, including PRs.
As it stands, the current setup just happens to test changes to master only.

Suggestions:

  • Update the Docker container instructions in the README.md:
    1. Add a comment that you must install the docker package first.
    2. Add a description on the usage of the docker -v option.
      Not everybody dumps files on their desktop.
      What to do when the files are in different directories?
  • Mention the other Docker Untrunc projects in the README.md.
  • Rename Dockerfile to Dockerfile-ubuntu, so one can easily add Docker containers based on different distros. Or maybe, even put it in a new dockers subdirectory.
  • Add a .dockerignore file.
  • And above all else, use Travis-CI for integration testing!
    You can use Travis-CI to test if the Docker-Untrunc executable can be build (and upload the successful build to a Docker Registry), but only when Travis-CI is used to test git master itself. There is no need to unnecessary increase the test time for PRs and non-master branches.
@brandon-dacrib
Copy link
Collaborator

This is a bit confusing. You said:

BUG: Travis-CI no longer tests the integration of Pull Request or any other branch except for master!

and then you said:

You can use Travis-CI to test if the Docker-Untrunc executable can be build (and upload the successful build to a Docker Registry), but only when Travis-CI is used to test git master itself. There is no need to unnecessary increase the test time for PRs and non-master branches.

Which do you want? Travis-CI to run on all branches, just PRs or just master?

@Hacklin
Copy link
Contributor Author

Hacklin commented Jun 7, 2018

Travis-CI runs on every source push (be it a PR or a git push to any branch in untrunc.git).
AFAIK, you cannot change this (in the free version).

In the .travis.yml you can tell using TRAVIS_* environment variables, if Travis-CI was run for a PR or not, and for which branch.
So you can program Travis-CI to only update the Docker-executable if the source push is to git master.
However, Travis-CI must always first do a test build to see if the source push is valid.

@Hacklin
Copy link
Contributor Author

Hacklin commented Jun 30, 2018

This is fixed by PR #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants