-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Travis-CI no longer tests the integration of PRs (commit f004f9c) #118
Comments
This is a bit confusing. You said:
and then you said:
Which do you want? Travis-CI to run on all branches, just PRs or just master? |
Travis-CI runs on every source push (be it a PR or a git push to any branch in In the |
This is fixed by PR #126 |
BUG: Travis-CI no longer tests the integration of Pull Request or any other branch except for master!
(Due to commit f004f9c)
Commit f004f9c hijacked Travis-CI to build a Docker executable from git master.
Travis-CI should be used to test the integration of any changes to the source, including PRs.
As it stands, the current setup just happens to test changes to master only.
For Docker executables see also:
(Uses an embedded builder Docker container to reduce the final executable size.)
Suggestions:
Docker container
instructions in theREADME.md
:docker
package first.-v
option.Not everybody dumps files on their desktop.
What to do when the files are in different directories?
README.md
.Dockerfile
toDockerfile-ubuntu
, so one can easily add Docker containers based on different distros. Or maybe, even put it in a newdockers
subdirectory..dockerignore
file.You can use Travis-CI to test if the Docker-Untrunc executable can be build (and upload the successful build to a Docker Registry), but only when Travis-CI is used to test git master itself. There is no need to unnecessary increase the test time for PRs and non-master branches.
The text was updated successfully, but these errors were encountered: