Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project is not discovered as changed or affected if test-only dependency component changed #515

Open
Foxomatic opened this issue Nov 24, 2024 · 0 comments

Comments

@Foxomatic
Copy link

Foxomatic commented Nov 24, 2024

Describe the bug
When using poly ws get:changes:changed-or-affected-projects :since stable to get changed projects with a project that contains a test alias dependency on a changed component, the project is not returned as changed or affected.

If I only change a test for a brick in a project that is required in actual production code (in src), the project is returned by poly ws get:changes:changed-or-affected-projects since:stable skip:development, so I assume, this is not intended behaviour.

To Reproduce

Project's deps.edn:

{:deps    poly/backend        {:local/root "../../bases/backend"}
          org.clojure/clojure {:mvn/version "1.11.4"}}
 :aliases {:test {:extra-paths []
                  :extra-deps  {poly/test-utils {:local/root "../../components/test-utils"}}}}}

I have a change (detected in (-> (polylith.clj.core.api.interface/workspace "stable") :changes :changed-components)) in the test-utils component and no other changes since stable.

A test namespace in the "backend" base requires the test-utils interface namespace.

When executing poly ws get:changes:changed-or-affected-projects since:stable skip:development (or (polylith.clj.core.api.interface/projects-to-deploy "stable")) an empty vector is returned. I would expect the project to be shown as changed or affected since the tests changed indirectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant