Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Web Plugin: Avoid known blocked id's/classes. #9

Open
Malvoz opened this issue May 26, 2019 · 1 comment
Open

[bug] Web Plugin: Avoid known blocked id's/classes. #9

Malvoz opened this issue May 26, 2019 · 1 comment

Comments

@Malvoz
Copy link
Contributor

Malvoz commented May 26, 2019

Adblockers (in this case: https://getadblock.com/) inject stylesheets, setting the display property to none for certain CSS selectors.

The Pollfish Web Plugin is affected by this stylesheet injection. The injected style: gdpr:not(body):not(html) { display: none !important } makes the entire element that wraps the "I agree" button (start survey) invisible to the users as shown below:

pollfish-blocked
.

While there are alot of filters, the one that includes the blocking style comes from:
https://easylist-downloads.adblockplus.org/fanboy-annoyance.txt

As an exmaple, changing the Web Plugin's gdpr class to gdpr-info makes the content visible again.


I also tested the web plugin with uBlock Origin with no issues, as far as I can tell.

@nikosrossolatos
Copy link
Contributor

@Malvoz nice work here ! I'll make a ticket to check against all css classes to fix this case (in case some went missing). Leaving this open so that we keep track of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants