Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max length for Bytes escape hatch #5990

Open
MOZGIII opened this issue Sep 28, 2024 · 0 comments
Open

Max length for Bytes escape hatch #5990

MOZGIII opened this issue Sep 28, 2024 · 0 comments

Comments

@MOZGIII
Copy link
Contributor

MOZGIII commented Sep 28, 2024

#2670 added a hard-coded limit to the max size of the Bytes struct; our runtime exceeds that size.

It is really a bad idea to have hard-coded limits like this, with no escape hatch; a better way to handle that would be an optional constructor argument for the max length with a default value; that way the said default value could be smaller, but adjusted when the context dictates it has to be bigger, or lifted entirely.

Like in our case - we are building some tooling to help us with runtime upgrade testing automation, and we really don't need any sort of fuss from the client-side like this at all - so we'd disable the max length and see where it gets us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant