-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polkadot-types-from-chain removes imports which are used later in the same file #5765
Comments
The error occurs only with Node versions 20 and above. |
This statement doesn't appear to be true! Locally I am seeing the same problem with Node v18.18.2. Here we see the same problem with v18.18.2. Actual diff & @smohan-dw do you have a Node version which you know to be working so that I can give it a try, instead of checking every possible version ? |
Node v18.18.2 is working fine for me. You can take a look at https://github.com/smohan-dw/cord.js/tree/sm-updates-0x3 |
The |
Rebuilding type definitions removes imports which are actually being used, which in turn results to build issues with my package later on.
I am expecting that these imports will not be removed.
Version:
@polkadot/typegen": "^10.10.1",
,"@polkadot/api": "^10.10.1",
Environment: Linux
Language:
** Steps to reproduce **
build:types
is defined asand I've identified that the removal of these imports is coming from
polkadot-types-from-chain
.gluwa/creditcoin3#95 - bumps versions of Polkadot.js packages and just rebuilds the type definitions and fails because of the error above - see the failing CI job
javascript-typecheck / cli
for examplegluwa/creditcoin3#99 - adds automatic regeneration of type definitions (will push an automatic commit to GitHub if successfull) and fails because of this very same issue - see the failing CI job
integration-test-cli
for example (actual diff in CI logs).The text was updated successfully, but these errors were encountered: