perf: Dedup binviews up front #20449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20449 +/- ##
=======================================
Coverage 78.99% 79.00%
=======================================
Files 1563 1563
Lines 220336 220326 -10
Branches 2488 2488
=======================================
- Hits 174063 174058 -5
+ Misses 45700 45695 -5
Partials 573 573 ☔ View full report in Codecov by Sentry. |
ritchie46
added a commit
that referenced
this pull request
Dec 26, 2024
This reverts commit 96b7a9a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@orlp FYI.
Instead of deduping for every view, I do a single dedup pass up front.