Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix zero-length len #18817

Merged
merged 1 commit into from
Sep 19, 2024
Merged

refactor(rust): Fix zero-length len #18817

merged 1 commit into from
Sep 19, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 18, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@8114b52). Learn more about missing BASE report.
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/reduce/convert.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18817   +/-   ##
=======================================
  Coverage        ?   79.85%           
=======================================
  Files           ?     1518           
  Lines           ?   205637           
  Branches        ?     2893           
=======================================
  Hits            ?   164219           
  Misses          ?    40870           
  Partials        ?      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit 506f927 into main Sep 19, 2024
22 checks passed
@orlp orlp deleted the fix-zero-len-len branch September 19, 2024 19:06
@c-peters c-peters added the accepted Ready for implementation label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants