Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression (particularly in q21 of the TPC-H benchmark, +60%) after specific commit #18828

Closed
2 tasks done
TNieuwdorp opened this issue Sep 19, 2024 · 1 comment
Closed
2 tasks done

Performance regression (particularly in q21 of the TPC-H benchmark, +60%) after specific commit #18828

TNieuwdorp opened this issue Sep 19, 2024 · 1 comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars

Comments

@TNieuwdorp
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

q21 of the TPC-H benchmark. Depending on system set-up had +60% runtime after this change.
(SCALE_OUTPUT=20.0, good runtime: 6.3, bad runtime: 10.4)

Log output

No response

Issue description

#17616 is the particular change that caused this regression.

Expected behavior

No increased runtime, but improved

Installed versions

Replace this line with a list of feature gates
@TNieuwdorp TNieuwdorp added bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars labels Sep 19, 2024
@TNieuwdorp
Copy link
Contributor Author

Fixed in 1.7.2! Not sure by what commit/PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TNieuwdorp