From 1c1574add6a0077aad69064e79c00414114fc28e Mon Sep 17 00:00:00 2001
From: Stijn de Gooijer <stijndegooijer@gmail.com>
Date: Tue, 29 Oct 2024 12:12:19 +0100
Subject: [PATCH] build(rust): Fix some feature flag issues (#19512)

---
 crates/polars-lazy/Cargo.toml        | 6 +++---
 crates/polars-plan/src/dsl/string.rs | 2 +-
 crates/polars-stream/Cargo.toml      | 4 ++++
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/crates/polars-lazy/Cargo.toml b/crates/polars-lazy/Cargo.toml
index a03b16fc7611..b7b3ad95bbac 100644
--- a/crates/polars-lazy/Cargo.toml
+++ b/crates/polars-lazy/Cargo.toml
@@ -71,7 +71,7 @@ temporal = [
 ]
 # debugging purposes
 fmt = ["polars-core/fmt", "polars-plan/fmt"]
-strings = ["polars-plan/strings", "polars-stream/strings"]
+strings = ["polars-plan/strings", "polars-stream?/strings"]
 future = []
 
 dtype-full = [
@@ -163,7 +163,7 @@ bitwise = [
   "polars-plan/bitwise",
   "polars-expr/bitwise",
   "polars-core/bitwise",
-  "polars-stream/bitwise",
+  "polars-stream?/bitwise",
   "polars-ops/bitwise",
 ]
 approx_unique = ["polars-plan/approx_unique"]
@@ -203,7 +203,7 @@ dynamic_group_by = [
   "temporal",
   "polars-expr/dynamic_group_by",
   "polars-mem-engine/dynamic_group_by",
-  "polars-stream/dynamic_group_by",
+  "polars-stream?/dynamic_group_by",
 ]
 ewma = ["polars-plan/ewma"]
 ewma_by = ["polars-plan/ewma_by"]
diff --git a/crates/polars-plan/src/dsl/string.rs b/crates/polars-plan/src/dsl/string.rs
index efa34f59c04c..2514d1a5f6a4 100644
--- a/crates/polars-plan/src/dsl/string.rs
+++ b/crates/polars-plan/src/dsl/string.rs
@@ -593,7 +593,7 @@ impl StringNameSpace {
         )
     }
 
-    #[cfg(feature = "strings")]
+    #[cfg(feature = "regex")]
     pub fn escape_regex(self) -> Expr {
         self.0.map_many_private(
             FunctionExpr::StringExpr(StringFunction::EscapeRegex),
diff --git a/crates/polars-stream/Cargo.toml b/crates/polars-stream/Cargo.toml
index d8c034341e3d..bc72dc649531 100644
--- a/crates/polars-stream/Cargo.toml
+++ b/crates/polars-stream/Cargo.toml
@@ -41,3 +41,7 @@ bitwise = ["polars-core/bitwise", "polars-plan/bitwise"]
 merge_sorted = ["polars-plan/merge_sorted"]
 dynamic_group_by = []
 strings = []
+
+# We need to specify default features here to match workspace defaults.
+# Otherwise we get warnings with cargo check/clippy.
+default = ["bitwise"]